APF-Tracker

Adventure PHP Framework Issue Management


View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000300Adventure PHP FrameworkBugpublic2016-05-10 16:302016-05-11 09:14
ReporterChristianAchatz 
Assigned ToChristianAchatz 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version3.2 
Target Version3.3Fixed in Version3.3 
Summary0000300: Application crushes with max execution time reached with missing space in tag definition
DescriptionIn case of tag definition

<fs:required-user-group>
   <fs:importdesign
attr1="..."
attr2="...">
      ...
   </fs:importdesign>
</fs:required-user-group>

application crashes with max execution time of 30s exceeded.
TagsNo tags attached.
Codereferenz: ([Datei]:[Zeile])
Namespacecore
Attached Files

- Relationships

-  Notes
(0000715)
ChristianAchatz (administrator)
2016-05-10 16:32
edited on: 2016-05-10 16:38

According to documentation, "\n" is not allowed in tag definitions. However, APF should not be running into exceeding execution time with improper tag definition but should be informing developers about the expectated definition.

(0000716)
ChristianAchatz (administrator)
2016-05-11 09:13

- Added "\n" detection to throw exception instead of running into an endless loop.
- Fixed in release-3.2 and master(https://github.com/AdventurePHP/code/commit/6443e88d97ffa3b6ef173783714bda53cb42afe4 [^]).
- New version can be doanloaded via composer update, GitHub, or ZIP download.
(0000717)
ChristianAchatz (administrator)
2016-05-11 09:14

Along with the fix, I've evaluated an extension to the parser detecting "\n" and using as tag delimiter the same way as " " (space). I'll follow up on that with release 3.3 development and evaluate whether an update to the parser is feasible in terms of performance.

- Issue History
Date Modified Username Field Change
2016-05-10 16:30 ChristianAchatz New Issue
2016-05-10 16:30 ChristianAchatz Status new => assigned
2016-05-10 16:30 ChristianAchatz Assigned To => ChristianAchatz
2016-05-10 16:32 ChristianAchatz Note Added: 0000715
2016-05-10 16:38 ChristianAchatz Note Edited: 0000715 View Revisions
2016-05-11 09:13 ChristianAchatz Note Added: 0000716
2016-05-11 09:14 ChristianAchatz Note Added: 0000717
2016-05-11 09:14 ChristianAchatz Status assigned => resolved
2016-05-11 09:14 ChristianAchatz Fixed in Version => 3.3
2016-05-11 09:14 ChristianAchatz Resolution open => fixed


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker